wenbingshen commented on code in PR #10767:
URL: https://github.com/apache/hudi/pull/10767#discussion_r1508541988
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/TestWriteCopyOnWrite.java:
##########
@@ -169,8 +169,10 @@ public void testPartialFailover() throws Exception {
.checkpointThrows(4, "Timeout(1000ms) while waiting for instant
initialize")
.assertEmptyEvent()
.subTaskFails(0, 3)
- // the last checkpoint instant was rolled back by subTaskFails(0, 2)
- // with EAGER cleaning strategy
+ // the last checkpoint instant can not rolled back by subTaskFails(0,
2)
Review Comment:
Agree. I added a new test and gave some reasons for the changes to the
original test:
In `INSERT` mode, only job-level restart can roll back the pending Instant.
When SubTasks fail to restart, the pending Instant needs to be reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
