danny0405 commented on code in PR #10797:
URL: https://github.com/apache/hudi/pull/10797#discussion_r1510454074
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -201,43 +202,40 @@ public static HoodieTableFileSystemView
createInMemoryFileSystemViewWithTimeline
/**
* Create a remote file System view for a table.
*
- * @param viewConf View Storage Configuration
+ * @param viewConf View Storage Configuration
* @param metaClient Hoodie Table MetaClient for the table.
- * @return
+ * @return {@link RemoteHoodieTableFileSystemView}
*/
private static RemoteHoodieTableFileSystemView
createRemoteFileSystemView(FileSystemViewStorageConfig viewConf,
- HoodieTableMetaClient metaClient) {
- LOG.info("Creating remote view for basePath " + metaClient.getBasePath() +
". Server="
- + viewConf.getRemoteViewServerHost() + ":" +
viewConf.getRemoteViewServerPort() + ", Timeout="
- + viewConf.getRemoteTimelineClientTimeoutSecs());
+
HoodieTableMetaClient metaClient) {
+ LOG.info("Creating remote view for basePath {}. Server={}:{}, Timeout={}",
metaClient.getBasePathV2(),
+ viewConf.getRemoteViewServerHost(),
viewConf.getRemoteViewServerPort(),
viewConf.getRemoteTimelineClientTimeoutSecs());
return new RemoteHoodieTableFileSystemView(metaClient, viewConf);
}
+ public static FileSystemViewManager createViewManagerWithTableMetadata(
+ final HoodieEngineContext context,
+ final HoodieMetadataConfig metadataConfig,
Review Comment:
Why this method is needful?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java:
##########
@@ -201,43 +202,40 @@ public static HoodieTableFileSystemView
createInMemoryFileSystemViewWithTimeline
/**
* Create a remote file System view for a table.
*
- * @param viewConf View Storage Configuration
+ * @param viewConf View Storage Configuration
* @param metaClient Hoodie Table MetaClient for the table.
- * @return
+ * @return {@link RemoteHoodieTableFileSystemView}
*/
private static RemoteHoodieTableFileSystemView
createRemoteFileSystemView(FileSystemViewStorageConfig viewConf,
- HoodieTableMetaClient metaClient) {
- LOG.info("Creating remote view for basePath " + metaClient.getBasePath() +
". Server="
- + viewConf.getRemoteViewServerHost() + ":" +
viewConf.getRemoteViewServerPort() + ", Timeout="
- + viewConf.getRemoteTimelineClientTimeoutSecs());
+
HoodieTableMetaClient metaClient) {
+ LOG.info("Creating remote view for basePath {}. Server={}:{}, Timeout={}",
metaClient.getBasePathV2(),
+ viewConf.getRemoteViewServerHost(),
viewConf.getRemoteViewServerPort(),
viewConf.getRemoteTimelineClientTimeoutSecs());
return new RemoteHoodieTableFileSystemView(metaClient, viewConf);
}
+ public static FileSystemViewManager createViewManagerWithTableMetadata(
+ final HoodieEngineContext context,
+ final HoodieMetadataConfig metadataConfig,
Review Comment:
Hmm, it's just a displacement of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
