suryaprasanna commented on code in PR #10648:
URL: https://github.com/apache/hudi/pull/10648#discussion_r1511826471
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -473,4 +478,52 @@ public void testRollbackWhenReplaceCommitIsPresent()
throws Exception {
context, table.getConfig(), table, rollbackInstant,
needRollBackInstant, true, false, true);
copyOnWriteRollbackActionExecutorForClustering.execute();
}
+
+ /**
+ * This method tests rollback of completed ingestion commits and
replacecommit inflight files
Review Comment:
My bad, I think the comment needs to be corrected. This case is actually
testing and scenario where rollback is completed but the inflight instants that
need to be removed are left.
That's why we recreating the instants using
=> writeClient.startCommitWithTime(secondCommit);
Thanks for catching this, will update the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
