danny0405 commented on code in PR #10786:
URL: https://github.com/apache/hudi/pull/10786#discussion_r1512029984
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1415,6 +1415,19 @@ public void
testBulkInsertRowWriterContinuousModeWithInlineClustering() throws E
getTableServicesConfigs(2000, "false", "true", "3", "false", ""));
}
+ @Test
+ public void
testBulkInsertRowWriterContinuousModeWithInlineClusteringAmbiguousDates()
throws Exception {
+
sparkSession.sqlContext().setConf("spark.sql.parquet.datetimeRebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.avro.datetimeRebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.parquet.int96RebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.parquet.datetimeRebaseModeInRead",
"LEGACY");
Review Comment:
This might be the use case we wanna to fix, is there any we can change this
timestamp generation as configurable for `HoodieTestDataGenerator`, the global
static variable has risk for configuration leak and it may be hard to
maintain/debug in the future.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1415,6 +1415,19 @@ public void
testBulkInsertRowWriterContinuousModeWithInlineClustering() throws E
getTableServicesConfigs(2000, "false", "true", "3", "false", ""));
}
+ @Test
+ public void
testBulkInsertRowWriterContinuousModeWithInlineClusteringAmbiguousDates()
throws Exception {
+
sparkSession.sqlContext().setConf("spark.sql.parquet.datetimeRebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.avro.datetimeRebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.parquet.int96RebaseModeInWrite",
"LEGACY");
+
sparkSession.sqlContext().setConf("spark.sql.parquet.datetimeRebaseModeInRead",
"LEGACY");
Review Comment:
This might be the use case we wanna fix, is there any we can change this
timestamp generation as configurable for `HoodieTestDataGenerator`, the global
static variable has risk for configuration leak and it may be hard to
maintain/debug in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
