danny0405 commented on code in PR #10820:
URL: https://github.com/apache/hudi/pull/10820#discussion_r1513671566
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -830,7 +830,7 @@ private static void
deletePendingIndexingInstant(HoodieTableMetaClient metaClien
protected static void checkNumDeltaCommits(HoodieTableMetaClient metaClient,
int maxNumDeltaCommitsWhenPending) {
final HoodieActiveTimeline activeTimeline =
metaClient.reloadActiveTimeline();
Option<HoodieInstant> lastCompaction =
activeTimeline.filterCompletedInstants()
- .filter(s -> s.getAction().equals(COMPACTION_ACTION)).lastInstant();
+ .filter(s -> s.getAction().equals(COMMIT_ACTION)).lastInstant();
Review Comment:
I'm wondering whether we should use the `COMPACTION_ACTION` for committed
instant in release 1.0.x, cc @vinothchandar ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
