boneanxs commented on code in PR #3936:
URL: https://github.com/apache/hudi/pull/3936#discussion_r1513731553
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/DeleteHoodieTableCommand.scala:
##########
@@ -56,32 +57,36 @@ case class DeleteHoodieTableCommand(deleteTable:
DeleteFromTable) extends Runnab
}
private def buildHoodieConfig(sparkSession: SparkSession): Map[String,
String] = {
- val targetTable = sparkSession.sessionState.catalog
- .getTableMetadata(tableId)
+ val targetTable =
sparkSession.sessionState.catalog.getTableMetadata(tableId)
+ val tblProperties = targetTable.storage.properties ++
targetTable.properties
val path = getTableLocation(targetTable, sparkSession)
val conf = sparkSession.sessionState.newHadoopConf()
val metaClient = HoodieTableMetaClient.builder()
.setBasePath(path)
.setConf(conf)
.build()
val tableConfig = metaClient.getTableConfig
- val primaryColumns =
HoodieOptionConfig.getPrimaryColumns(targetTable.storage.properties)
Review Comment:
As far as I know, hudi currently uses `spark.sql.caseSensitive` to choose
caseSensitive or not during analyze stage, and by default it's false, so it
might be reasonable that we need to respect that configure as well here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
