yihua commented on code in PR #10778:
URL: https://github.com/apache/hudi/pull/10778#discussion_r1519038535
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieStreamerUtils.java:
##########
@@ -105,7 +108,11 @@ public static Option<JavaRDD<HoodieRecord>>
createHoodieRecords(HoodieStreamer.C
avroRecords.add(Either.left(new
HoodieAvroRecord<>(hoodieKey, payload)));
} catch (Exception e) {
if (!shouldErrorTable) {
- throw e;
+ if (!(e instanceof HoodieKeyException || e instanceof
HoodieKeyGeneratorException)) {
+ throw new HoodieRecordCreationException("Failed to
create Hoodie Avro Record", e);
+ } else {
+ throw e;
+ }
Review Comment:
Wrap this into a util method since the same functionality is used twice?
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -478,10 +479,16 @@ class HoodieSparkSqlWriterInternal {
}
instantTime = client.createNewInstantTime()
// Convert to RDD[HoodieRecord]
- val hoodieRecords =
-
HoodieCreateRecordUtils.createHoodieRecordRdd(HoodieCreateRecordUtils.createHoodieRecordRddArgs(df,
- writeConfig, parameters, avroRecordName, avroRecordNamespace,
writerSchema,
- processedDataSchema, operation, instantTime,
preppedSparkSqlWrites, preppedSparkSqlMergeInto, preppedWriteOperation))
+ try {
+
+ }
Review Comment:
should this be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
