jonvex commented on code in PR #10858:
URL: https://github.com/apache/hudi/pull/10858#discussion_r1523937143
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -574,12 +574,12 @@ private InputBatch
fetchNextBatchFromSource(Option<String> resumeCheckpointStr,
checkpointStr = dataAndCheckpoint.getCheckpointForNextBatch();
if (this.userProvidedSchemaProvider != null &&
this.userProvidedSchemaProvider.getTargetSchema() != null
&& this.userProvidedSchemaProvider.getTargetSchema() !=
InputBatch.NULL_SCHEMA) {
+ // Let's deduce the schema provider for writer side first!
+ schemaProvider =
getDeducedSchemaProvider(this.userProvidedSchemaProvider.getTargetSchema(),
this.userProvidedSchemaProvider, metaClient);
Review Comment:
Not necessarily. But adding this definitely won't make things worse.
Previously, we were just using the schema provider without validating the
schema at all, so even if the validation isn't strict enough, it is still
better than no validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
