codope commented on code in PR #10851:
URL: https://github.com/apache/hudi/pull/10851#discussion_r1524123795
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -118,28 +120,32 @@ public class HoodieCleanConfig extends HoodieConfig {
+ "the minimum number of file slices to retain in each file group,
during cleaning.");
public static final ConfigProperty<String> CLEAN_TRIGGER_STRATEGY =
ConfigProperty
- .key("hoodie.clean.trigger.strategy")
+ .key("hoodie.cleaner.trigger.strategy")
.defaultValue(CleaningTriggerStrategy.NUM_COMMITS.name())
+ .withAlternatives("hoodie.clean.trigger.strategy")
Review Comment:
Thanks for the aligning the configs. Can you please make sure that the
change is backwards compatible? Basically, we need to make sure
`ConfigUtils.get*WithAltKeys` is called on the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
