danny0405 commented on code in PR #10820:
URL: https://github.com/apache/hudi/pull/10820#discussion_r1524569229
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -2901,6 +2904,42 @@ public void testMetadataTableWithLongLog() throws
Exception {
assertTrue(t.getMessage().startsWith(String.format("Metadata table's
deltacommits exceeded %d: ", maxNumDeltacommits)));
}
+ @Test
+ public void testMORCheckNumDeltaCommits() throws Exception {
+ init(MERGE_ON_READ, true);
+ final int maxNumDeltaCommits = 3;
+ writeConfig = getWriteConfigBuilder(true, true, false)
+ .withMetadataConfig(HoodieMetadataConfig.newBuilder()
+ .enable(true)
+ .enableMetrics(false)
+ .withMaxNumDeltaCommitsBeforeCompaction(maxNumDeltaCommits
- 1)
+ .withMaxNumDeltacommitsWhenPending(maxNumDeltaCommits)
+ .build())
+ .build();
+ initWriteConfigAndMetatableWriter(writeConfig, true);
+ // write deltacommits to data-table and do compaction in metadata-table
(with commit-instant)
+ doWriteOperation(testTable, HoodieInstantTimeGenerator.formatDate(new
Date()));
+ doWriteOperation(testTable, HoodieInstantTimeGenerator.formatDate(new
Date()));
+ // ensure the compaction is triggered and executed
+ try (HoodieBackedTableMetadata metadata = new
HoodieBackedTableMetadata(context, writeConfig.getMetadataConfig(),
writeConfig.getBasePath(), true)) {
+ HoodieTableMetaClient metadataMetaClient =
metadata.getMetadataMetaClient();
+ final HoodieActiveTimeline activeTimeline =
metadataMetaClient.reloadActiveTimeline();
+ Option<HoodieInstant> lastCompaction =
activeTimeline.filterCompletedInstants()
+ .filter(s -> s.getAction().equals(COMMIT_ACTION)).lastInstant();
+ assertTrue(lastCompaction.isPresent());
+ // create pending instant in data table
+ testTable.addRequestedCommit(HoodieInstantTimeGenerator.formatDate(new
Date()));
+ // continue writing
+ while
(activeTimeline.reload().getDeltaCommitTimeline().findInstantsAfter(lastCompaction.get().getTimestamp()).countInstants()
<= maxNumDeltaCommits) {
Review Comment:
Keep cautious the while loop may cause resource leaks. We better make this
test commits deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
