vinishjail97 commented on code in PR #10869:
URL: https://github.com/apache/hudi/pull/10869#discussion_r1525369671
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestCheckpointUtils.java:
##########
@@ -104,26 +105,35 @@ public void testComputeOffsetRangesWithoutMinPartitions()
{
ranges = CheckpointUtils.computeOffsetRanges(makeOffsetMap(new int[] {0,
1}, new long[] {200000, 250000}),
makeOffsetMap(new int[] {0, 1, 2}, new long[] {200010, 350000,
10000}), 100000, 0);
assertEquals(100000, CheckpointUtils.totalNewMessages(ranges));
+ assertEquals(5, ranges.length);
+ assertEquals(0, ranges[0].partition());
assertEquals(10, ranges[0].count());
- assertEquals(89990, ranges[1].count());
- assertEquals(10000, ranges[2].count());
Review Comment:
The skew caused by the current approach the different can be more if the
last partition to be exhausted has the highest number of backlog messages to be
consumed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
