wombatu-kun commented on code in PR #10870:
URL: https://github.com/apache/hudi/pull/10870#discussion_r1527501760
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -326,12 +327,7 @@ private MetadataValues
populateMetadataFields(HoodieRecord<T> hoodieRecord) {
private void initNewStatus() {
HoodieDeltaWriteStat prevStat = (HoodieDeltaWriteStat)
this.writeStatus.getStat();
// Make a new write status and copy basic fields over.
- HoodieDeltaWriteStat stat = new HoodieDeltaWriteStat();
- stat.setFileId(fileId);
- stat.setPartitionPath(partitionPath);
- stat.setPrevCommit(prevStat.getPrevCommit());
- stat.setBaseFile(prevStat.getBaseFile());
- stat.setLogFiles(new ArrayList<>(prevStat.getLogFiles()));
Review Comment:
No, i haven't found similar new instance creation in other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
