empcl commented on code in PR #10840:
URL: https://github.com/apache/hudi/pull/10840#discussion_r1527763448
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/catalog/HoodieCatalog.java:
##########
@@ -345,7 +345,7 @@ public void createTable(ObjectPath tablePath,
CatalogBaseTable catalogTable, boo
options.put(TableOptionProperties.PARTITION_COLUMNS, partitions);
final String[] pks =
conf.getString(FlinkOptions.RECORD_KEY_FIELD).split(",");
- boolean complexHoodieKey = pks.length > 1 ||
resolvedTable.getPartitionKeys().size() > 1;
+ boolean complexHoodieKey = pks.length > 1 ||
partitions.split(",").length > 1;
Review Comment:
I think there's no problem. The partitions field is also linked by commas,
and it's reasonable for me to check the number of partitions separated by
commas. If you think it's unreasonable, could you please provide a demo so that
I can reflect on it
<img width="838" alt="iShot_2024-03-18_11 41 55"
src="https://github.com/apache/hudi/assets/28925346/a3bd438a-10e9-4369-a86f-f9b99bb15d90";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
