yihua commented on code in PR #10866:
URL: https://github.com/apache/hudi/pull/10866#discussion_r1529100966
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -2418,15 +2418,15 @@ public void testSqlSourceSource() throws Exception {
@Disabled
@Test
public void testJdbcSourceIncrementalFetchInContinuousMode() {
- try (Connection connection =
DriverManager.getConnection("jdbc:h2:mem:test_mem", "test", "jdbc")) {
+ try (Connection connection =
DriverManager.getConnection("jdbc:h2:mem:test_mem", "sa", "")) {
Review Comment:
Looks like this is from another fix. Could the JDBC user and password be
put into static variables to avoid any misconfigs in tests in the future?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJdbcSource.java:
##########
@@ -438,7 +438,7 @@ public void testSourceWithStorageLevel() {
private void writeSecretToFs() throws IOException {
FileSystem fs = FileSystem.get(new Configuration());
FSDataOutputStream outputStream = fs.create(new
Path("file:///tmp/hudi/config/secret"));
- outputStream.writeBytes("jdbc");
+ outputStream.writeBytes("");
Review Comment:
Similar here for the password. And should we add the password back for
testing the secret (this refactoring of static variables and password should be
in a separate PR)?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJdbcSource.java:
##########
@@ -73,12 +73,12 @@ public static void beforeAll() throws Exception {
@BeforeEach
public void setup() throws Exception {
super.setup();
- PROPS.setProperty("hoodie.deltastreamer.jdbc.url", "jdbc:h2:mem:test_mem");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.driver.class",
"org.h2.Driver");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.user", "test");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.password", "jdbc");
- PROPS.setProperty("hoodie.deltastreamer.jdbc.table.name", "triprec");
- connection = DriverManager.getConnection("jdbc:h2:mem:test_mem", "test",
"jdbc");
+ PROPS.setProperty("hoodie.streamer.jdbc.url", "jdbc:h2:mem:test_mem");
+ PROPS.setProperty("hoodie.streamer.jdbc.driver.class", "org.h2.Driver");
+ PROPS.setProperty("hoodie.streamer.jdbc.user", "sa");
+ PROPS.setProperty("hoodie.streamer.jdbc.password", "");
+ PROPS.setProperty("hoodie.streamer.jdbc.table.name", "triprec");
+ connection = DriverManager.getConnection("jdbc:h2:mem:test_mem", "sa", "");
Review Comment:
Similar here for the JDBC user name and password.
##########
hudi-utilities/src/test/resources/streamer-config/invalid_hive_sync_uber_config.properties:
##########
@@ -18,6 +18,6 @@
include=base.properties
hoodie.datasource.write.recordkey.field=_row_key
hoodie.datasource.write.partitionpath.field=created_at
-hoodie.deltastreamer.source.kafka.topic=test_topic
-hoodie.deltastreamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
-hoodie.deltastreamer.keygen.timebased.input.dateformat=yyyy-MM-dd
\ No newline at end of file
+hoodie.streamer.source.kafka.topic=test_topic
+hoodie.streamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
Review Comment:
reminder for fixing keygen config.
##########
hudi-utilities/src/test/resources/streamer-config/uber_config.properties:
##########
@@ -18,10 +18,10 @@
include=base.properties
hoodie.datasource.write.recordkey.field=_row_key
hoodie.datasource.write.partitionpath.field=created_at
-hoodie.deltastreamer.source.kafka.topic=topic1
-hoodie.deltastreamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
-hoodie.deltastreamer.keygen.timebased.input.dateformat=yyyy-MM-dd HH:mm:ss.S
+hoodie.streamer.source.kafka.topic=topic1
+hoodie.streamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
Review Comment:
reminder for fixing keygen config.
##########
hudi-utilities/src/test/resources/streamer-config/short_trip_uber_config.properties:
##########
@@ -18,11 +18,11 @@
include=base.properties
hoodie.datasource.write.recordkey.field=_row_key
hoodie.datasource.write.partitionpath.field=created_at
-hoodie.deltastreamer.source.kafka.topic=topic2
-hoodie.deltastreamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
-hoodie.deltastreamer.keygen.timebased.input.dateformat=yyyy-MM-dd HH:mm:ss.S
+hoodie.streamer.source.kafka.topic=topic2
+hoodie.streamer.keygen.timebased.timestamp.type=UNIX_TIMESTAMP
Review Comment:
reminder for fixing keygen config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
