danny0405 commented on code in PR #10857: URL: https://github.com/apache/hudi/pull/10857#discussion_r1533338519
########## hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithGreaterRecordPayload.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.model; + +import org.apache.avro.generic.GenericRecord; +import org.apache.avro.generic.IndexedRecord; +import org.apache.hudi.avro.HoodieAvroUtils; +import org.apache.hudi.common.util.ConfigUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.keygen.constant.KeyGeneratorOptions; + +import java.util.Properties; + +public class OverwriteWithGreaterRecordPayload extends DefaultHoodieRecordPayload { + + public OverwriteWithGreaterRecordPayload(GenericRecord record, Comparable orderingVal) { + super(record, orderingVal); + } + + public OverwriteWithGreaterRecordPayload(Option<GenericRecord> record) { + super(record); + } + + @Override + public OverwriteWithLatestAvroPayload preCombine(OverwriteWithLatestAvroPayload oldValue) { + if (oldValue.recordBytes.length == 0) { + // use natural order for delete record + return this; + } + if (oldValue.orderingVal.compareTo(orderingVal) >= 0) { + // pick the payload with greatest ordering value + return oldValue; + } else { + return this; + } + } + + @Override + protected boolean needUpdatingPersistedRecord(IndexedRecord currentValue, + IndexedRecord incomingRecord, Properties properties) { + /* + * Combining strategy here returns currentValue on disk if incoming record is older absolutely. + * The incoming record can be either a delete (sent as an upsert with _hoodie_is_deleted set to true) + * or an insert/update record. In any case, if it is older absolutely than the record in disk, the currentValue + * in disk is returned (to be rewritten with new commit time). + */ Review Comment: Can we add some UT for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
