nsivabalan commented on pull request #1912: URL: https://github.com/apache/hudi/pull/1912#issuecomment-670295868
Synced up with @bvaradar on the diff. Here are some changes/conclusions we narrowed down after our discussion. - We felt exposing TimedWaitOnAppearCG to external users may not make much sense. We do not want to make TimedWaitOnAppear as the global consistency guard in all places, but it is very specific to finalizeWrite code path. - And so, instead of defining a config for consistencyGuardClass, we will introduce a config in ConsistencyGuard (for lack of better word, lets say "simplifyFailSafeConsistencyToTimedSleep/simplifyFailSafeConsistencyToTimedWait" for now). Will enable this config by default in which case TimedWaitOnAppearCG will be used in finalize Write. If users wish to use FailSafeCG even in finalizeWrite code paths, they can disable this config value on which FailSafeCG will be used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
