nsivabalan commented on a change in pull request #1858:
URL: https://github.com/apache/hudi/pull/1858#discussion_r466991187
##########
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -186,10 +188,14 @@ public HoodieMetrics getMetrics() {
* Get HoodieTable and init {@link Timer.Context}.
*
* @param operationType write operation type
+ * @param instantTime current inflight instant time
* @return HoodieTable
*/
- protected HoodieTable getTableAndInitCtx(WriteOperationType operationType) {
+ protected HoodieTable getTableAndInitCtx(WriteOperationType operationType,
String instantTime) {
HoodieTableMetaClient metaClient = createMetaClient(true);
+ if (config.shouldRollbackUsingMarkers()) {
Review comment:
this was my thinking behind this guard. If someone wishes to stay with
list based rollback, why execute this upgrade this which specifically does some
work to assist in marker based rollback which will never be used since marked
based rollback is not going to be used at all. I am not very strong on this
though. But tests need some fixes though as I rely on creating commits and
marker files using client at first, by disabling marker based rollback. If we
remove this guard, then tests need to manually create all data files and marker
files. I am not saying that as a reason to keep this guard, just saying we have
some extra work to be done.
##########
File path:
hudi-client/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -63,4 +84,156 @@ static HoodieRollbackStat
mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
return new HoodieRollbackStat(stat1.getPartitionPath(),
successDeleteFiles, failedDeleteFiles, commandBlocksCount);
}
+ /**
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
