beyond1920 commented on code in PR #10898:
URL: https://github.com/apache/hudi/pull/10898#discussion_r1537150194
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/HoodieSimpleBucketIndex.java:
##########
@@ -61,6 +63,15 @@ public Map<Integer, HoodieRecordLocation>
loadBucketIdToFileIdMappingForPartitio
if (!bucketIdToFileIdMapping.containsKey(bucketId)) {
bucketIdToFileIdMapping.put(bucketId, new
HoodieRecordLocation(commitTime, fileId));
} else {
+ // If hoodie.write.bucketid.conflict.rollback.enable enable,
rollback unfinished replacement instant
Review Comment:
1. Rollback the `replacement` commit is not a good solution. Because it the
not the only one possibility caused multiple base fileids belongs to the same
bucket
2. Besides, rollback in the foreach loop does not make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
