yihua commented on code in PR #10909:
URL: https://github.com/apache/hudi/pull/10909#discussion_r1537958935
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RowCustomColumnsSortPartitioner.java:
##########
@@ -51,7 +51,7 @@ public RowCustomColumnsSortPartitioner(String[] columnNames,
HoodieWriteConfig c
public Dataset<Row> repartitionRecords(Dataset<Row> records, int
outputSparkPartitions) {
return records
.sort(Arrays.stream(sortColumnNames).map(Column::new).toArray(Column[]::new))
- .coalesce(outputSparkPartitions);
+ .repartition(outputSparkPartitions);
Review Comment:
Should the `.coalesce` happen before `.sort` to control the parallelism? Is
that the reason why the parallelism is not honored in the global sorting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
