bvaradar commented on code in PR #10898:
URL: https://github.com/apache/hudi/pull/10898#discussion_r1538086015
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -187,6 +187,14 @@ public HoodieTimeline filterPendingReplaceTimeline() {
s -> s.getAction().equals(HoodieTimeline.REPLACE_COMMIT_ACTION) &&
!s.isCompleted()), details);
}
+ @Override
+ public HoodieTimeline filterPendingCommitTimeline() {
Review Comment:
Instead of adding new API. can you use
timeline.getCommitsTimeline().filterInflightsAndRequested()
We do not want to add new APIs in HoodieTimeline unless it is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]