danny0405 commented on code in PR #10923:
URL: https://github.com/apache/hudi/pull/10923#discussion_r1538467737
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -512,25 +509,18 @@ public Option<HoodieInstant> getFirstNonSavepointCommit()
{
}
@Override
- public Option<HoodieInstant> getLastClusterCommit() {
- return Option.fromJavaOptional(getCommitsTimeline().filter(s ->
s.getAction().equalsIgnoreCase(HoodieTimeline.REPLACE_COMMIT_ACTION))
+ public Option<HoodieInstant> getLastCompleteOrPendingClusteringInstant() {
Review Comment:
Kind of think the name `getLastClusteringInstant` should be fine, by default
it includes all the states of clustering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
