the-other-tim-brown commented on code in PR #10858:
URL: https://github.com/apache/hudi/pull/10858#discussion_r1538545545
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -255,6 +256,31 @@ public class StreamSync implements Serializable, Closeable
{
private final boolean useRowWriter;
+ @VisibleForTesting
+ StreamSync(HoodieStreamer.Config cfg, SparkSession sparkSession,
Review Comment:
The idea here is to make sure that the constructors are similar so you test
a class that mirrors what is going to happen in production. If there is too
much divergence between the constructors, we may think we've tested a path that
is untested. In this case it's probably fine since we have a lot of functional
tests around the StreamSync functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
