yihua commented on code in PR #10913:
URL: https://github.com/apache/hudi/pull/10913#discussion_r1539972497
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedTableMetadata.java:
##########
@@ -285,6 +297,112 @@ public void testMetadataRecordKeyExcludeFromPayload(final
HoodieTableType tableT
validateMetadata(testTable);
}
+ /**
+ * This tests the case where the two clean actions delete the same file and
commit
+ * to the metadata table. The metadata table should not contain the deleted
file afterwards.
+ * A new cleaner plan may contain the same file to delete if the previous
cleaner
+ * plan has not been successfully executed before the new one is scheduled.
+ */
+ @ParameterizedTest
+ @EnumSource(HoodieTableType.class)
Review Comment:
This one runs quickly as the data files are dummy. Given the criticality of
MDT logic, I think it's still worthwhile adding a functional tests here to make
sure assumption is intact.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedTableMetadata.java:
##########
@@ -285,6 +297,112 @@ public void testMetadataRecordKeyExcludeFromPayload(final
HoodieTableType tableT
validateMetadata(testTable);
}
+ /**
+ * This tests the case where the two clean actions delete the same file and
commit
+ * to the metadata table. The metadata table should not contain the deleted
file afterwards.
+ * A new cleaner plan may contain the same file to delete if the previous
cleaner
+ * plan has not been successfully executed before the new one is scheduled.
+ */
+ @ParameterizedTest
+ @EnumSource(HoodieTableType.class)
Review Comment:
This one runs quickly as the data files are dummy. Given the criticality of
MDT logic, I think it's still worthwhile adding functional tests here to make
sure the assumption in core logic is intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
