yihua commented on code in PR #10922:
URL: https://github.com/apache/hudi/pull/10922#discussion_r1540282903
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -281,15 +269,11 @@ private void scanInternalV1(Option<KeySpec> keySpecOpt) {
LOG.info("Reading a data block from file " + logFile.getPath() + "
at instant " + instantTime);
// store the current block
currentInstantLogBlocks.push(logBlock);
- validLogBlockInstants.add(logBlock);
Review Comment:
Got it. I think it's better to put such cleanup changes in a separate PR
next time so it's easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]