yihua commented on code in PR #10866:
URL: https://github.com/apache/hudi/pull/10866#discussion_r1545123027
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/config/SourceTestConfig.java:
##########
@@ -21,29 +21,36 @@
import org.apache.hudi.common.config.ConfigProperty;
+import static
org.apache.hudi.common.util.ConfigUtils.DELTA_STREAMER_CONFIG_PREFIX;
+import static org.apache.hudi.common.util.ConfigUtils.STREAMER_CONFIG_PREFIX;
+
/**
* Configurations for Test Data Sources.
*/
public class SourceTestConfig {
public static final ConfigProperty<Integer> NUM_SOURCE_PARTITIONS_PROP =
ConfigProperty
- .key("hoodie.deltastreamer.source.test.num_partitions")
+ .key(STREAMER_CONFIG_PREFIX + "source.test.num_partitions")
Review Comment:
Could you also check the usages of all the `ConfigProperty` definitions and
replace all config fetching using `.key()`, e.g.,
`props.getInteger(SourceTestConfig.MAX_UNIQUE_RECORDS_PROP.key(),
SourceTestConfig.MAX_UNIQUE_RECORDS_PROP.defaultValue());`, with `ConfigUtils`
APIs, e.g., `getStringWithAltKeys`, `getLongWithAltKeys`, etc.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
