danny0405 commented on code in PR #10941:
URL: https://github.com/apache/hudi/pull/10941#discussion_r1545518905


##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/TableCommand.java:
##########
@@ -85,13 +87,25 @@ public String connect(
       @ShellOption(value = {"--maxWaitIntervalMs"}, defaultValue = "300000",
           help = "Max wait time for eventual consistency") final Integer 
maxConsistencyIntervalMs,
       @ShellOption(value = {"--maxCheckIntervalMs"}, defaultValue = "7",
-          help = "Max checks for eventual consistency") final Integer 
maxConsistencyChecks)
+          help = "Max checks for eventual consistency") final Integer 
maxConsistencyChecks,
+      @ShellOption(value = {"--timeGeneratorType"}, defaultValue = 
"WAIT_TO_ADJUST_SKEW",
+          help = "Time generator type, which is used to generate globally 
monotonically increasing timestamp") final String timeGeneratorType,
+      @ShellOption(value = {"--maxExpectedClockSkewMs"}, defaultValue = "200",

Review Comment:
   So the 3 new added options are all optional right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to