wombatu-kun commented on code in PR #10942:
URL: https://github.com/apache/hudi/pull/10942#discussion_r1545900885


##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/execution/bulkinsert/JavaGlobalSortPartitioner.java:
##########
@@ -31,12 +32,21 @@
  *
  * @param <T> HoodieRecordPayload type
  */
-public class JavaGlobalSortPartitioner<T>
-    implements BulkInsertPartitioner<List<HoodieRecord<T>>> {
+public class JavaGlobalSortPartitioner<T> implements 
BulkInsertPartitioner<List<HoodieRecord<T>>> {
+
+  public JavaGlobalSortPartitioner() {
+  }
+
+  /**
+   * Constructor to create as UserDefinedBulkInsertPartitioner class via 
reflection
+   * @param config HoodieWriteConfig

Review Comment:
   This partitioner will be instantiated when user define write config property 
`hoodie.bulkinsert.user.defined.partitioner.class=org.apache.hudi.execution.bulkinsert.JavaGlobalSortPartitioner`.
  
   This constructor will be called via reflection in methods of DataSourceUtils 
class `createUserDefinedBulkInsertPartitioner(HoodieWriteConfig config)` and 
`createUserDefinedBulkInsertPartitionerWithRows(HoodieWriteConfig config)`.  
   There is nothing to customize in this JavaGlobalSortPartitioner, but, for 
example, provided writeConfig is used for customization  of 
RowSpatialCurveSortPartitioner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to