bvaradar commented on code in PR #10955:
URL: https://github.com/apache/hudi/pull/10955#discussion_r1548866685
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndexWithSQL.scala:
##########
@@ -155,4 +156,36 @@ class TestRecordLevelIndexWithSQL extends
RecordLevelIndexTestBase {
val readDf = spark.read.format("hudi").options(hudiOpts).load(basePath)
readDf.registerTempTable(sqlTempTable)
}
+
+ @Test
+ def testInFilterOnNonRecordKey(): Unit = {
Review Comment:
@bhat-vinay : Can you confirm if this unit-test fails without your change in
RecordLevelIndexSupport.scala
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/RecordLevelIndexSupport.scala:
##########
@@ -162,7 +162,10 @@ class RecordLevelIndexSupport(spark: SparkSession,
case inQuery: In =>
var validINQuery = true
inQuery.value match {
- case _: AttributeReference =>
+ case attribute: AttributeReference =>
Review Comment:
Good catch !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
