wombatu-kun commented on code in PR #10949:
URL: https://github.com/apache/hudi/pull/10949#discussion_r1550791467
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/ddl/TestSpark3DDL.scala:
##########
@@ -742,6 +744,8 @@ class TestSpark3DDL extends HoodieSparkSqlTestBase {
option("hoodie.schema.on.read.enable","true").
option("hoodie.datasource.write.reconcile.schema","true").
option(DataSourceWriteOptions.TABLE_NAME.key(), tableName).
+ option(HoodieWriteConfig.WRITE_PAYLOAD_CLASS_NAME.key(),
classOf[OverwriteWithLatestAvroPayload].getName).
Review Comment:
This test was written for `OverwriteWithLatestAvroPayload` and it checks
OverwriteWithLatest behavior, i think it's better to let it be. Or may be add
the same test and make it pass by using new default payloads. But...
All other tests use default payload and pass. Why it is not enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
