wombatu-kun opened a new pull request, #10963:
URL: https://github.com/apache/hudi/pull/10963
### Change Logs
I found in `FSUtils` class:
```
// TODO: this should be removed
public static String makeBaseFileName(String instantTime, String
writeToken, String fileId)
```
This method (without fileExtension param) is not used in main code at all,
but has heavy usage (>100 referencies) in tests.
I removed it and fixed all depending tests by calling extended version of
`makeBaseFileName` (with default base file extension as argument).
So now there is only one `makeBaseFileName` method for all cases, and there
is no possibility to make base file name with default extension mistakenly.
### Impact
none
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
