codope commented on code in PR #10860:
URL: https://github.com/apache/hudi/pull/10860#discussion_r1554953956
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -434,7 +433,12 @@ private boolean initializeFromFilesystem(String
initializationTime, List<Metadat
fileGroupCountAndRecordsPair = initializeRecordIndexPartition();
break;
case FUNCTIONAL_INDEX:
- fileGroupCountAndRecordsPair =
initializeFunctionalIndexPartition();
+ Set<String> functionalIndexPartitionsToInit =
getFunctionalIndexPartitionsToInit();
+ if (functionalIndexPartitionsToInit.isEmpty()) {
+ continue;
Review Comment:
Adding to what Vinay said, going forward we will have more indexes where
index type and index name (mdt partition name) will differ such as secondary
index. I think we should get rid of `MetadataPartitionType`. This also enables
removing the `MetadataRecordsGenerationParams` pojo which is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
