prashantwason commented on PR #10641: URL: https://github.com/apache/hudi/pull/10641#issuecomment-2045987807
Sure. I can put out a patch for b. later. If you have tested the writer side metrics emitted as per this change for MDT then this is good to go. On Mon, Apr 8, 2024 at 8:50 PM Sivabalan Narayanan ***@***.***> wrote: > hey @prashantwason <https://github.com/prashantwason> : lets de-couple > the fixes. > a. Fixing MDT to emit writer side metrics(commit duration, compaction > duration etc) > b. Fixing MDT to emit reader side metrics (col stats look up duration etc) > during distributed registry. > > I feel we should focus on (a) in this patch and get it landed. and you can > put out a patch (I assume you folks already have a fix) for distributed > registry based metrics from the executor. > > If you are aligned on that, let us know if you have any feedback on this > patch. or if we are good to go ahead. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/hudi/pull/10641#issuecomment-2044100016>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AN55SS3G7RSP3O7GKEUIZEDY4NQPJAVCNFSM6AAAAABC7SK2ZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGEYDAMBRGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
