danny0405 commented on code in PR #10648:
URL: https://github.com/apache/hudi/pull/10648#discussion_r1560153283
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -892,9 +893,25 @@ protected Map<String, Option<HoodiePendingRollbackInfo>>
getPendingRollbackInfos
String instantToRollback =
rollbackPlan.getInstantToRollback().getCommitTime();
if (ignoreCompactionAndClusteringInstants) {
if (!HoodieTimeline.COMPACTION_ACTION.equals(action)) {
- boolean isClustering =
HoodieTimeline.REPLACE_COMMIT_ACTION.equals(action)
- && ClusteringUtils.getClusteringPlan(metaClient, new
HoodieInstant(true, action, instantToRollback)).isPresent();
- if (!isClustering) {
+ HoodieInstant requestedInstant = new
HoodieInstant(HoodieInstant.State.REQUESTED, action, instantToRollback);
Review Comment:
Don't think this change is minor, can we assign a JIRA task to trace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
