nsivabalan commented on code in PR #11000:
URL: https://github.com/apache/hudi/pull/11000#discussion_r1562262882
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -268,6 +268,7 @@ public boolean commitStats(String instantTime,
HoodieData<WriteStatus> writeStat
commitCallback.call(new HoodieWriteCommitCallbackMessage(
instantTime, config.getTableName(), config.getBasePath(), stats,
Option.of(commitActionType), extraMetadata));
}
+ releaseResources(instantTime);
Review Comment:
this covers all writers correct? spark ds writer, and deltastreamer?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -268,6 +268,7 @@ public boolean commitStats(String instantTime,
HoodieData<WriteStatus> writeStat
commitCallback.call(new HoodieWriteCommitCallbackMessage(
instantTime, config.getTableName(), config.getBasePath(), stats,
Option.of(commitActionType), extraMetadata));
}
+ releaseResources(instantTime);
Review Comment:
this code path covers all writers correct? spark ds writer, and
deltastreamer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
