danny0405 commented on code in PR #10915:
URL: https://github.com/apache/hudi/pull/10915#discussion_r1568087606


##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCExtractor.java:
##########
@@ -114,6 +114,24 @@ public Map<HoodieFileGroupId, List<HoodieCDCFileSplit>> 
extractCDCFileSplits() {
     ValidationUtils.checkState(commits != null, "Empty commits");
 
     Map<HoodieFileGroupId, List<HoodieCDCFileSplit>> fgToCommitChanges = new 
HashMap<>();
+

Review Comment:
   > we are looking to parse and fetch base files for dc1 and dc2 as well which 
could have been cleaned up by the cleaner and may not exists.
   
   Are you saying the cleaning state has changed because of the archiving? If 
that is true, maybe we should just adjust the cleaning strategy to keep more 
historical commits.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to