wombatu-kun opened a new pull request, #11042:
URL: https://github.com/apache/hudi/pull/11042
### Change Logs
Clean up literal usage in Hudi CLI argument check:
- added min arguments count as an int field to SparkCommand enum, and now
there is a single literal usage for each command (instead of 5 that was
before);
- added args count validation methods to SparkCommand;
- extracted common logic of additional configs creation to `makeConfigs`
method in SparkCommand;
- extracted common logic of getting propsFilePath to `getPropsFilePath`
method in SparkCommand;
- called args validation and configs/propsFilePath computations for all
values before the `switch(cmd)`
- fixed logging;
- reused `ArchiveExecutorUtils.archive()` method for `archive` command
execution.
### Impact
none
### Risk level (write none, low medium or high below)
none
### Documentation Update
none
- _The config description must be updated if new configs are added or the
default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website.
Please create a Jira ticket, attach the
ticket number here and follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to
make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
