[
https://issues.apache.org/jira/browse/HUDI-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HUDI-4228:
---------------------------------
Labels: pull-request-available (was: )
> Clean up literal usage in Hudi CLI argument check
> -------------------------------------------------
>
> Key: HUDI-4228
> URL: https://issues.apache.org/jira/browse/HUDI-4228
> Project: Apache Hudi
> Issue Type: Improvement
> Components: cli
> Reporter: Ethan Guo
> Assignee: Vova Kolmakov
> Priority: Minor
> Labels: pull-request-available
>
> In "org.apache.hudi.cli.commands.SparkMain", the logic for checking number of
> arguments for different Hudi CLI commands is hardcoded with literals like
> this:
> {code:java}
> case COMPACT_RUN:
> assert (args.length >= 10);
> propsFilePath = null;
> if (!StringUtils.isNullOrEmpty(args[9])) {
> propsFilePath = args[9];
> }
> configs = new ArrayList<>();
> if (args.length > 10) {
> configs.addAll(Arrays.asList(args).subList(9, args.length));
> }
> returnCode = compact(jsc, args[3], args[4], args[5],
> Integer.parseInt(args[6]), args[7],
> Integer.parseInt(args[8]), HoodieCompactor.EXECUTE, propsFilePath,
> configs);
> break; {code}
> We should have a better way of validating this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
