yihua commented on code in PR #11048: URL: https://github.com/apache/hudi/pull/11048#discussion_r1569860811
########## hudi-io/src/test/java/org/apache/hudi/io/storage/TestHoodieStorageBase.java: ########## @@ -148,6 +150,46 @@ public void testCreateWriteAndRead() throws IOException { assertTrue(storage.createDirectory(path4)); } + @Test + public void testSeekable() throws IOException { + HoodieStorage storage = getHoodieStorage(); + StoragePath path = new StoragePath(getTempDir(), "testSeekable/1.file"); + assertFalse(storage.exists(path)); + byte[] data = new byte[] {2, 42, 49, (byte) 158, (byte) 233, 66, 9, 34, 79}; Review Comment: Because for values larger than 127 it has to cast from int to byte (or have to use negative value here, which is not going to be readable). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org