danny0405 commented on code in PR #11047:
URL: https://github.com/apache/hudi/pull/11047#discussion_r1570022625
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/storage/hadoop/HoodieHadoopStorage.java:
##########
@@ -94,7 +94,7 @@ public boolean createDirectory(StoragePath path) throws
IOException {
}
@Override
- public List<StoragePathInfo> listDirectEntries(StoragePath path) throws
IOException {
+ public List<StoragePathInfo> listDirectory(StoragePath path) throws
IOException {
Review Comment:
Kind of think people would be confused by the two `listFiles` and
`listDirectory`, the former is to list the given path and return all the file
paths contained underneath it, the later is to list the **directory** which
means the given path must be a directory(do we have validation for that)? The
naming convention is differnet when comparing these two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
