jonvex commented on code in PR #10957:
URL: https://github.com/apache/hudi/pull/10957#discussion_r1571111108
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -231,7 +231,13 @@ private static Option<Schema.Field> findNestedField(Schema
schema, String[] fiel
if (!nestedPart.isPresent()) {
return Option.empty();
}
- return nestedPart;
+ boolean isUnion = false;
Review Comment:
Before, this just found the field and returned it. Now it returns the entire
path to the field.
so if the record was
{
a: string
b: {
x: long
y:int
}
}
before, the method would just return "y:int".
Now, the method will return "b:{y:int}".
this is so when we call appendFieldsToSchemaDedupNested we can dedup the
field if it already exists.
For example, before if we tried to append "y:int" to the schema we would get
{
a: string
b: {
x: long
y:int
}
y:int
}
now, that we append "b:{y:int}" we will get
{
a: string
b: {
x: long
y:int
}
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
