danny0405 commented on code in PR #11052:
URL: https://github.com/apache/hudi/pull/11052#discussion_r1571751773
##########
hudi-io/src/main/java/org/apache/hudi/storage/HoodieStorage.java:
##########
@@ -267,7 +270,7 @@ public final void createImmutableFileInPath(StoragePath
path,
if (content.isPresent() && needTempFile) {
StoragePath parent = path.getParent();
- tmpPath = new StoragePath(parent, path.getName() + TMP_PATH_POSTFIX);
+ tmpPath = new StoragePath(parent, path.getName() + "." +
UUID.randomUUID());
Review Comment:
The method itself would take care of the file deletion, the original logic
also has this concen, and to be worse, if a corrupt tmp file already exists,
the file creation would never succeed. That is the best we can do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
