umehrot2 commented on a change in pull request #1944:
URL: https://github.com/apache/hudi/pull/1944#discussion_r468797076
##########
File path: packaging/hudi-presto-bundle/pom.xml
##########
@@ -76,7 +76,12 @@
<include>org.apache.hbase:hbase-common</include>
<include>org.apache.hbase:hbase-protocol</include>
<include>org.apache.hbase:hbase-server</include>
+ <include>org.apache.hbase:hbase-annotations</include>
<include>org.apache.htrace:htrace-core</include>
+ <include>com.yammer.metrics:metrics-core</include>
+ <include>com.google.guava:guava</include>
Review comment:
These dependencies are fixes for runtime issues. `guava` is there is the
class-path but there is a runtime mismatch. The main problem is coming in due
to `hbase` dependencies, and they conflict with the `presto` versions. Let me
try to provide the stack traces if that helps.
About the licensing:
- https://mvnrepository.com/artifact/com.yammer.metrics/metrics-core
- https://mvnrepository.com/artifact/com.google.guava/guava
- https://mvnrepository.com/artifact/commons-lang/commons-lang
- https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java =>
this seems to be **BSD License**. So is this going to be an issue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
