danny0405 commented on code in PR #11073:
URL: https://github.com/apache/hudi/pull/11073#discussion_r1578937570
##########
pom.xml:
##########
@@ -2040,6 +2040,27 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <goals>
+ <goal>prepare-agent</goal>
+ </goals>
+ </execution>
+ <execution>
Review Comment:
It looks like it is very tricky to make the report-aggregate work, based on
these links:
- https://groups.google.com/g/jacoco/c/FpdLbxsXSTY
-
https://github.com/jacoco/jacoco/blob/master/jacoco-maven-plugin.test/it/it-report-aggregate/report/pom.xml
Basically if we wanna to make the aggrerator work, we should have a
separate module named `hudi-reporter` that adds the correspendent denpendencies
for the multiple moldules that we want to report, otherwise, we always got
empty report files.
But some modules are actually dinamically loaded based on the active maven
compile profile, which makes the issue even more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
