codope commented on code in PR #11077: URL: https://github.com/apache/hudi/pull/11077#discussion_r1579846213
########## hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java: ########## @@ -81,7 +83,7 @@ public class HoodieMergedLogRecordScanner extends AbstractHoodieLogRecordReader // A timer for calculating elapsed time in millis public final HoodieTimer timer = HoodieTimer.create(); // Map of compacted/merged records - private final ExternalSpillableMap<String, HoodieRecord> records; + private final ExternalSpillableMap<HoodieMergeKey, HoodieRecord> records; Review Comment: I don't think there is a major perf regression on non-SI path. We are creating only new objects, not doing any further compute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
