yihua commented on code in PR #11059:
URL: https://github.com/apache/hudi/pull/11059#discussion_r1580706672
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -669,25 +663,23 @@ private HoodieTableMetaClient initializeMetaClient()
throws IOException {
* @return List consisting of {@code DirectoryInfo} for each partition found.
*/
private List<DirectoryInfo> listAllPartitionsFromFilesystem(String
initializationTime) {
- List<SerializablePath> pathsToList = new LinkedList<>();
- pathsToList.add(new SerializablePath(new
CachingPath(dataWriteConfig.getBasePath())));
+ List<StoragePath> pathsToList = new LinkedList<>();
+ pathsToList.add(new StoragePath(dataWriteConfig.getBasePath()));
List<DirectoryInfo> partitionsToBootstrap = new LinkedList<>();
final int fileListingParallelism =
metadataWriteConfig.getFileListingParallelism();
- SerializableConfiguration conf = new
SerializableConfiguration(dataMetaClient.getHadoopConf());
final String dirFilterRegex =
dataWriteConfig.getMetadataConfig().getDirectoryFilterRegex();
final String datasetBasePath = dataMetaClient.getBasePathV2().toString();
- SerializablePath serializableBasePath = new SerializablePath(new
CachingPath(datasetBasePath));
+ StoragePath storageBasePath = new StoragePath(datasetBasePath);
while (!pathsToList.isEmpty()) {
// In each round we will list a section of directories
int numDirsToList = Math.min(fileListingParallelism, pathsToList.size());
// List all directories in parallel
engineContext.setJobStatus(this.getClass().getSimpleName(), "Listing " +
numDirsToList + " partitions from filesystem");
List<DirectoryInfo> processedDirectories =
engineContext.map(pathsToList.subList(0, numDirsToList), path -> {
- FileSystem fs = path.get().getFileSystem(conf.get());
- String relativeDirPath =
FSUtils.getRelativePartitionPath(serializableBasePath.get(), path.get());
- return new DirectoryInfo(relativeDirPath, fs.listStatus(path.get()),
initializationTime);
+ String relativeDirPath =
FSUtils.getRelativePartitionPath(storageBasePath, path);
+ return new DirectoryInfo(relativeDirPath,
metadataMetaClient.getStorage().listDirectEntries(path), initializationTime);
Review Comment:
@wombatu-kun we cannot directly use `metadataMetaClient` as Spark serializes
this object and sends it from the driver to the executor. Serialization of the
meta client is heavy-weight and we avoid that, so we only only serialize the
configuration instead before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
