yihua commented on code in PR #10806:
URL: https://github.com/apache/hudi/pull/10806#discussion_r1581442892
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/testutils/UtilitiesTestBase.java:
##########
@@ -266,6 +268,17 @@ public void teardown() throws Exception {
TestDataSource.resetDataGen();
}
+ private static Map<String, String> sparkConf() {
+ Map<String, String> conf = new HashMap<>();
+ conf.put("spark.default.parallelism", "2");
+ conf.put("spark.sql.shuffle.partitions", "2");
+ conf.put("spark.executor.memory", "1G");
+ conf.put("spark.driver.memory", "1G");
+ conf.put("spark.hadoop.mapred.output.compress", "true");
+ conf.put("spark.ui.enable", "false");
Review Comment:
In a follow-up PR, we can unify these configs with
`HoodieClientTestUtils#getSparkConfForTest`
https://github.com/apache/hudi/blob/550367cdbda37fdf8a33d0a6ce71354915099c72/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java#L91
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamerTestBase.java:
##########
@@ -157,9 +155,9 @@ public void cleanupKafkaTestUtils() {
public static void initClass() throws Exception {
UtilitiesTestBase.initTestServices(false, true, false);
// basePath is defined in UtilitiesTestBase.initTestServices
- PARQUET_SOURCE_ROOT = basePath + "/parquetFiles";
- ORC_SOURCE_ROOT = basePath + "/orcFiles";
- JSON_KAFKA_SOURCE_ROOT = basePath + "/jsonKafkaFiles";
+ PARQUET_SOURCE_ROOT = basePath + "parquetFiles";
Review Comment:
Any reason to change the source root paths here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
