[ 
https://issues.apache.org/jira/browse/HUDI-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xi chaomin updated HUDI-7685:
-----------------------------
    Description: 
After cherry pick [https://github.com/apache/hudi/pull/9723] I find the delete 
partition action can‘t commit. Auto commit in HoodieSparkSqlWriter is disabled, 
while SparkDeletePartitionCommitActionExecutor calls commitOnAutoCommit to 
commit the instant.

 
DataSourceUtils -> createHoodieConfig
{code:java}
// code placeholder
HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
    .withPath(basePath).withAutoCommit(false).combineInput(combineInserts, 
true); {code}
 

SparkDeletePartitionCommitActionExecutor -> commitOnAutoCommit
{code:java}
// code placeholder
protected void commitOnAutoCommit(HoodieWriteMetadata result) {
  // validate commit action before committing result
  runPrecommitValidators(result);
  if (config.shouldAutoCommit()) {
    LOG.info("Auto commit enabled: Committing " + instantTime);
    autoCommit(result);
  } else {
    LOG.info("Auto commit disabled for " + instantTime);
  }
} {code}

  was:After cherry pick [https://github.com/apache/hudi/pull/9723] I find the 
delete partition action can‘t commit. Auto commit in HoodieSparkSqlWriter is 
disabled, while SparkDeletePartitionCommitActionExecutor calls 
commitOnAutoCommit to commit the instant.


> Fix bug in partition TTL
> ------------------------
>
>                 Key: HUDI-7685
>                 URL: https://issues.apache.org/jira/browse/HUDI-7685
>             Project: Apache Hudi
>          Issue Type: Bug
>            Reporter: xi chaomin
>            Priority: Major
>
> After cherry pick [https://github.com/apache/hudi/pull/9723] I find the 
> delete partition action can‘t commit. Auto commit in HoodieSparkSqlWriter is 
> disabled, while SparkDeletePartitionCommitActionExecutor calls 
> commitOnAutoCommit to commit the instant.
>  
> DataSourceUtils -> createHoodieConfig
> {code:java}
> // code placeholder
> HoodieWriteConfig.Builder builder = HoodieWriteConfig.newBuilder()
>     .withPath(basePath).withAutoCommit(false).combineInput(combineInserts, 
> true); {code}
>  
> SparkDeletePartitionCommitActionExecutor -> commitOnAutoCommit
> {code:java}
> // code placeholder
> protected void commitOnAutoCommit(HoodieWriteMetadata result) {
>   // validate commit action before committing result
>   runPrecommitValidators(result);
>   if (config.shouldAutoCommit()) {
>     LOG.info("Auto commit enabled: Committing " + instantTime);
>     autoCommit(result);
>   } else {
>     LOG.info("Auto commit disabled for " + instantTime);
>   }
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to