xicm commented on code in PR #11117:
URL: https://github.com/apache/hudi/pull/11117#discussion_r1582610908
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/ttl/strategy/KeepByTimeStrategy.java:
##########
@@ -103,7 +103,7 @@ private Map<String, Option<String>>
getLastCommitTimeForPartitions(List<String>
* @param referenceTime last commit time or creation time for partition
*/
protected boolean isPartitionExpired(String referenceTime) {
- String expiredTime =
instantTimePlusMillis(fixInstantTimeCompatibility(referenceTime), ttlInMilis);
+ String expiredTime = instantTimePlusMillis(referenceTime, ttlInMilis);
Review Comment:
fixInstantTimeCompatibility is called in instantTimePlusMillis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
