xicm commented on code in PR #11117:
URL: https://github.com/apache/hudi/pull/11117#discussion_r1584042433
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkPartitionTTLActionExecutor.java:
##########
@@ -47,11 +49,22 @@ public SparkPartitionTTLActionExecutor(HoodieEngineContext
context, HoodieWriteC
@Override
public HoodieWriteMetadata<HoodieData<WriteStatus>> execute() {
+ HoodieWriteMetadata<HoodieData<WriteStatus>> emptyResult = new
HoodieWriteMetadata<>();
+ emptyResult.setPartitionToReplaceFileIds(Collections.emptyMap());
+ emptyResult.setWriteStatuses(context.emptyHoodieData());
try {
PartitionTTLStrategy strategy =
HoodiePartitionTTLStrategyFactory.createStrategy(table, config.getProps(),
instantTime);
List<String> expiredPartitions = strategy.getExpiredPartitionPaths();
+ if (expiredPartitions.isEmpty()) {
+ return emptyResult;
+ }
LOG.info("Partition ttl find the following expired partitions to delete:
" + String.join(",", expiredPartitions));
- return new SparkDeletePartitionCommitActionExecutor<>(context, config,
table, instantTime, expiredPartitions).execute();
+ // Auto commit is disabled in config, copy config and enable auto commit
for SparkDeletePartitionCommitActionExecutor.
+ HoodieWriteConfig autoCommitConfig =
HoodieWriteConfig.newBuilder().withProperties(config.getProps()).withAutoCommit(true).build();
+ return new SparkDeletePartitionCommitActionExecutor<>(context,
autoCommitConfig, table, instantTime, expiredPartitions).execute();
Review Comment:
Flink side: FlinkWriteClients -> getHoodieClientConfig
Spark side: DataSourceUtils -> createHoodieConfig
all set auto commit to false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
