bvaradar commented on code in PR #11123:
URL: https://github.com/apache/hudi/pull/11123#discussion_r1584177880
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/strategy/CompactionStrategy.java:
##########
@@ -102,4 +105,19 @@ public List<HoodieCompactionOperation>
orderAndFilter(HoodieWriteConfig writeCon
public List<String> filterPartitionPaths(HoodieWriteConfig writeConfig,
List<String> allPartitionPaths) {
return allPartitionPaths;
}
+
+ /**
+ * Creates a new instance of the provided class.
+ * @param strategyClass class name of the strategy
+ * @param hoodieEngineContext an engine context which may be used by the
compaction strategy
+ * @param hoodieTable a hoodie table which may be used by the compaction
strategy
+ * @return a new instance of the provided class
+ */
+ public static CompactionStrategy create(String strategyClass,
HoodieEngineContext hoodieEngineContext, HoodieTable hoodieTable) {
Review Comment:
@the-other-tim-brown HoodieTable interface exposes different write APIs
(insertXXX, bulkInsertXXX, upsertXXX, deleteXXX) which should not be called by
the CompactionStrategy implementation.
Can you define an interface to expose the subset of APIs that you want to
compaction strategy implementation to make use of ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
